Comment by 🎵 random-elephant
Re: "BBS has been updated to a work-in-progress version of…"
Thanks !
2024-08-21 · 2 years ago
8 Later Comments ↓
🦆 CitySlicker · 2024-08-21 at 22:00:
comment action that merges the comment into the previous post in the thread, if the authors are the same
Thanks for this. I think will help posts sorted under the “hotness” algorithm. So you can’t just bump your own post to the top
🌆 skyjake [OP/mod...] · 2024-08-22 at 03:30:
@CitySlicker The hotness ranking already does take that into account. It's the number of individual people commenting instead of the comments that counts.
In addition to keeping things tidier, the merging action will help write long comments easier since one does not have to go into composer mode for that.
🚀 mbays · 2024-08-24 at 19:19:
@skyjake Nice to see the edit parameter here. I tried it in my koreader client, but get a bubble error that NoneType has no parameter startswith. Any idea what that could mean?
🌆 skyjake [OP/mod...] · 2024-08-25 at 05:04:
Looks like my code assumes the Titan "mime" parameter is always included in the request, even though it should be optional. The code is trying to check that the MIME type of the edited content is text.
I guess your client doesn't send "mime"? I'll update Bubble to assume it's text if unspecified, maybe just detecting valid UTF-8 encoding.
EDIT: Fix applied.
🚀 mbays · 2024-08-25 at 16:26:
@skyjake Thanks, it seems that is the problem -- my client omits the mime param if it's text/gemini, and if I set it to text/plain instead then editing works. However, I'm using the present tense because I still get the same error on editing with no mime parameter.
🌆 skyjake [OP/mod...] · 2024-08-25 at 16:35:
Thanks for testing. I applied another fix. I missed a second usage of the mime parameter... At least now when I modify Lagrange to omit "mime", it works for me. (Should've tested properly the first time, sorry.)
🚀 mbays · 2024-08-27 at 11:51:
@skyjake Thanks, now it works! Much better UI than the old approach.
🌆 skyjake [OP/mod...] · 2024-08-27 at 12:03:
Great!
Yeah I agree, the edit actions are perfectly suited for this use case. :)
Original Post
BBS has been updated to a work-in-progress version of Bubble. There are a couple of useful additions so far: comment action that merges the comment into the previous post in the thread, if the authors are the same support for the Titan "edit" parameter for a more seamless text editing experience (requires client support!) In addition to the comment author, moderators and the admin have the ability to merge comments. I'll be applying this in cases where the same user comments multiple times...